Skip to content

Create smoketest for SLM#950

Merged
trhille merged 7 commits into
MPAS-Dev:mainfrom
matthewhoffman:landice/slm-smoketest
Apr 21, 2026
Merged

Create smoketest for SLM#950
trhille merged 7 commits into
MPAS-Dev:mainfrom
matthewhoffman:landice/slm-smoketest

Conversation

@matthewhoffman
Copy link
Copy Markdown
Member

@matthewhoffman matthewhoffman commented Mar 30, 2026 •
edited
Loading

This PR refactors the landice/slm test group to support the existing mesh convergence test, as well as a new smoke test. The smoke test sets up and runs the SLM coupled within MALI for the circular ice sheet geometry (a prescribed ice-sheet evolution case with no ice-sheet dynamics). This approximates running the SLM in standalone mode and is suited for an integration test.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@matthewhoffman
Reorganize slm test group
4a35c0a 
* rename the test group to slm_circ_icesheet
* move the convergence test to a test case called
  slm_circ_icesheet_mesh_convergence.
* Move resources and modules around

This is to support a separate smoketest that will reuse modules and
resources.
@matthewhoffman
Minor adjustments to get mesh_convergence to set up
f391305
@matthewhoffman matthewhoffman marked this pull request as draft March 30, 2026 02:49
@matthewhoffman matthewhoffman added land ice in progress This PR is not ready for review or merging labels Mar 30, 2026
@matthewhoffman
Add slm_circ_icesheet smoke test
41b7b9c 
This is a second test case in the test group that runs a simple smoke
test.
@matthewhoffman
Update docs
7c64344
@matthewhoffman matthewhoffman force-pushed the landice/slm-smoketest branch from 2cc557c to 7c64344 Compare March 30, 2026 03:09
@matthewhoffman matthewhoffman force-pushed the landice/slm-smoketest branch from a4c08d5 to 77ee6e2 Compare April 4, 2026 05:09
@matthewhoffman matthewhoffman marked this pull request as ready for review April 4, 2026 05:35
@matthewhoffman matthewhoffman force-pushed the landice/slm-smoketest branch from dcccf60 to ea4f1e4 Compare April 4, 2026 05:40
@matthewhoffman
Copy link
Copy Markdown
Member Author

matthewhoffman commented Apr 4, 2026

Testing

I ran the full_integration suite with the new test after compiling MALI with SLM=true and confirmed it runs successfully. Because it is just a smoke test to catch regressions, there is no test validation.
Setup:

compass setup -t landice/slm_circ_icesheet/smoke_test -w /pscratch/sd/h/hoffman2/COMPASS/slm-smoke-test2

Result:

landice/slm_circ_icesheet/smoke_test
  * step: setup_mesh
  * step: run_model
  test execution:      SUCCESS
  test runtime:        03:36
Test Runtimes:
03:36 PASS landice_slm_circ_icesheet_smoke_test
Total runtime 03:49
PASS: All passed successfully!

Because this test only can be easily run on perlmutter due to the required SLM input files, and it takes a few minutes to run, I am not adding it to a test suite. If we can get Love numbers generated for the SLM at coarser resolution, this test could be made faster and those files put on the input data server in order to add this test to a test suite. But that is not currently an easy option, and I'd like to get this merged in its present form.

@matthewhoffman matthewhoffman requested a review from trhille April 4, 2026 06:27
@matthewhoffman matthewhoffman removed the in progress This PR is not ready for review or merging label Apr 4, 2026
@matthewhoffman
Copy link
Copy Markdown
Member Author

matthewhoffman commented Apr 4, 2026

@trhille , this can probably just be given a quick once over.

trhille
trhille approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@trhille trhille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @matthewhoffman. This looks great! I'm approving based on inspection and your testing.

@trhille trhille merged commit d387e50 into MPAS-Dev:main Apr 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trhille trhille trhille approved these changes

Assignees

No one assigned

Labels

land ice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewhoffman @trhille